Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cre2: 0.3.0 -> 0.3.6 #66014

Merged
merged 1 commit into from Aug 17, 2019
Merged

cre2: 0.3.0 -> 0.3.6 #66014

merged 1 commit into from Aug 17, 2019

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Aug 5, 2019 •
edited

Motivation for this change

fixing packages that rryantm is failing to upgrade

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

$ nix-review pr 66014
...
[1 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/66014
1 package were build:
cre2

aanderse
aanderse approved these changes Aug 17, 2019
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty straight forward. i's dotted, t's crossed. LGTM 👍
As always thank you for your awesome work @jonringer!

@aanderse aanderse merged commit c2c1340 into NixOS:master Aug 17, 2019
@jonringer jonringer deleted the update-cre2 branch August 17, 2019 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanderse aanderse aanderse approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @aanderse