Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: 369fe2ada8eb
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: a2253f442d3f
Choose a head ref
  • 6 commits
  • 4 files changed
  • 1 contributor

Commits on Aug 5, 2019

  1. gtk3: defines for debugging, disable cast checks 

    Because we're using plain buildtype these have to be
passed manually.

See: https://gitlab.gnome.org/GNOME/gtk/blob/3.24.10/meson.build#L59

With autotools the mapping for the the options to the defines was:

yes:     G_ENABLE_DEBUG G_ENABLE_CONSISTENCY_CHECKS
minimum: G_ENABLE_DEBUG G_DISABLE_CAST_CHECKS
no:      G_DISABLE_CAST_CHECKS G_DISABLE_ASSERT G_DISABLE_CHECKS

So we're passing the exact ones that would've been used for minimum.

Additionally it isn't a good idea to pass the equivalents used for "no" 
as it eliminates G_ENABLE_DEBUG which disables pre-condition checks and 
assertions. The actual option only existed to serve people who needed a 
specific build of GTK for very specific environments. And now they are
much better served with meson's plain buildtype and figuring out what to
pass themselves.
    @worldofpeace
    worldofpeace committed Aug 5, 2019
    Copy the full SHA
    27a71a1 View commit details
    Browse the repository at this point in the history

  2. glib: add cflag G_DISABLE_CAST_CHECKS 

    This is what would have been passed before with the release
buildtype.

See: https://gitlab.gnome.org/GNOME/glib/blob/2.60.4/meson.build#L208
    @worldofpeace
    worldofpeace committed Aug 5, 2019
    Copy the full SHA
    60266eb View commit details
    Browse the repository at this point in the history

  3. gnome3.gnome-settings-daemon: add cflag G_DISABLE_CAST_CHECKS 

    This is what would have been passed before with the release
buildtype.

See: https://gitlab.gnome.org/GNOME/gnome-settings-daemon/blob/GNOME_SETTINGS_DAEMON_3_32_1/meson.build#L73
    @worldofpeace
    worldofpeace committed Aug 5, 2019
    Copy the full SHA
    c7c727f View commit details
    Browse the repository at this point in the history

  4. pantheon.elementary-settings-daemon: add cflag G_DISABLE_CAST_CHECKS 

    Mirror c7c727f.
    @worldofpeace
    worldofpeace committed Aug 5, 2019
    Copy the full SHA
    3b085b4 View commit details
    Browse the repository at this point in the history

  5. glib: drop define BSD_COMP 

    I fail to see where or for what it is useful for.
    @worldofpeace
    worldofpeace committed Aug 5, 2019
    Copy the full SHA
    f2eddec View commit details
    Browse the repository at this point in the history

  6. Merge pull request #65850 from worldofpeace/bye-g-disable-checks 

    glib,gtk: correct CLAGS for plain buildtype
    @worldofpeace
    worldofpeace committed Aug 5, 2019
    Copy the full SHA
    a2253f4 View commit details
    Browse the repository at this point in the history