Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

solaar: unstable -> 1.0.1 #65847

Merged
merged 1 commit into from Sep 17, 2019
Merged

solaar: unstable -> 1.0.1 #65847

merged 1 commit into from Sep 17, 2019

Conversation

ysndr
Copy link
Member

@ysndr ysndr commented Aug 3, 2019

Motivation for this change

Keep track with the releases that were continued to be issued by the solaar devs and contain the recent development.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @ysndr

@ysndr
Copy link
Member Author

ysndr commented Aug 14, 2019

@spinus Do you need to have a look at this?

spinus
spinus approved these changes Aug 14, 2019
View reviewed changes
Copy link
Member

@spinus spinus left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thank you for taking care of this @ysndr !

@spinus
Copy link
Member

spinus commented Aug 14, 2019

@ysndr actually I spot small issue, but it was not in the change so I didn't spot at first. Could you update homepage as well?

@spinus
Copy link
Member

spinus commented Aug 14, 2019

and potentially commit description should match pattern when you upgrade version. https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#submitting-changes

@ysndr ysndr changed the title solaar: track latest release and set correct repo owner solaar: unstable -> 1.0.1 Aug 14, 2019
@ysndr
Copy link
Member Author

ysndr commented Aug 14, 2019

Could you update homepage as well?
Yeah totally missed that as well

@spinus
Copy link
Member

spinus commented Aug 15, 2019

good stuff, cheers

@bjornfor
Copy link
Contributor

This needs a rebase.

@ysndr
solaar: track latest release and set correct repo owner
128b839 
Update project homepage

Drop 'unstable' package name attribute
@ysndr
Copy link
Member Author

ysndr commented Sep 16, 2019

so finally after struggling with getting my local fork up to date I guess this will work now
@bjornfor / @spinus who is responsible for getting this merged?

@ofborg ofborg bot requested a review from spinus September 16, 2019 10:52
@spinus
Copy link
Member

spinus commented Sep 16, 2019

@ysndr I have no merge writes

@bjornfor bjornfor merged commit 84d4243 into NixOS:master Sep 17, 2019
@bjornfor
Copy link
Contributor

Thanks!

@ysndr ysndr deleted the update/solaar branch September 17, 2019 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjornfor bjornfor bjornfor approved these changes

@spinus spinus Awaiting requested review from spinus

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ysndr @spinus @bjornfor