Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dependency and patch files (refs: #65786) #65957

Merged
merged 1 commit into from Aug 6, 2019
Merged

Add dependency and patch files (refs: #65786) #65957

merged 1 commit into from Aug 6, 2019

Conversation

ysndr
Copy link
Member

@ysndr ysndr commented Aug 4, 2019

Motivation for this change

Should resolve #65786.

@Moredread would you like to test?

Things done

Added missing library and applied patch that was circulating as a fix for another bug in the arch user repository comment section

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @7c6f434c

@ofborg ofborg bot requested a review from 7c6f434c August 4, 2019 16:33
@7c6f434c
Copy link
Member

7c6f434c commented Aug 5, 2019

@GrahamcOfBorg build love_0_7

@Moredread
Copy link
Contributor

@GrahamcOfBorg build rimshot

@7c6f434c 7c6f434c merged commit 735ca8b into NixOS:master Aug 6, 2019
@ysndr ysndr deleted the fix/love_0_7 branch August 9, 2019 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Moredread Moredread Moredread approved these changes

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Love 0.7 broken on master and 19.03
3 participants
@ysndr @7c6f434c @Moredread