Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mdbook: 0.1.8 -> 0.3.1 #65890

Merged
merged 2 commits into from Aug 6, 2019
Merged

mdbook: 0.1.8 -> 0.3.1 #65890

merged 2 commits into from Aug 6, 2019

Conversation

tazjin
Copy link
Member

@tazjin tazjin commented Aug 4, 2019

Motivation for this change

Last update in nixpkgs was over a year ago and the project has progressed a lot in between. This moves the derivation to the latest tagged version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @Havvy

@tazjin
mdbook: 0.1.8 -> 0.3.1
e19185e 
Last update was over a year ago and the project has progressed a lot
in between. This moves the derivation to the latest tagged version.
@tazjin tazjin mentioned this pull request Aug 4, 2019
Closed
9 tasks
srhb
srhb requested changes Aug 4, 2019
View reviewed changes
Copy link
Contributor

@srhb srhb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the license is (now?) mpl20, not asl20 or mit.

@tazjin
Copy link
Member Author

tazjin commented Aug 4, 2019

@srhb You're right! It looks like the license has always been MPL 2.0, so I'm not sure where that came from originally. Updated it, but I can't resolve your comment because it's outside of the original diff and Github won't render it correctly.

@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/50

@samueldr
Copy link
Member

samueldr commented Aug 5, 2019

Is this comment from the previous PR still relevant? rust-docs/team#23 is not resolved. I'm not even 100% sure I understand it, is it that it would break our rust builds since its documentation wouldn't build?

@tazjin
Copy link
Member Author

tazjin commented Aug 5, 2019

@samueldr As far as I can tell, our Rust builds do not depend on mdbook (in fact nothing does, as per rg -i 'mdbook'). The Rust documentation that we do build as part of the standard platform is just what rustdoc creates, which is separate from the book(s).

Hence I don't think this comment is relevant for nixpkgs, but if a Nix user wants to contribute to upstream Rust books they will need to get an older version of the tool to build them.

@adisbladis adisbladis merged commit 6b135bf into NixOS:master Aug 6, 2019
@tazjin tazjin deleted the chore/bump-mdbook-0.3.1 branch August 6, 2019 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srhb srhb srhb approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tazjin @nixos-discourse @samueldr @srhb @adisbladis