Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: m-labs/nmigen
base: d0ac8bf78940
Choose a base ref
...
head repository: m-labs/nmigen
compare: 34a97b27512a
Choose a head ref
  • 2 commits
  • 2 files changed
  • 1 contributor

Commits on Aug 4, 2019

  1. back.rtlil: use a dummy wire, not 'x, when assigning to shorter LHS.

    Using 'x is legal RTLIL, in theory, but in practice it crashes Yosys
    and when it doesn't, it causes Yosys to produce invalid Verilog.
    Using a dummy wire is always safe and is not a major readability
    issue as this is a rare corner case.
    
    (It is not trivial to shorten the RHS in this case, because during
    expansion of an ArrayProxy, match_shape() could be called in
    a context far from the RHS handling logic.)
    whitequark committed Aug 4, 2019
    Configuration menu
    Copy the full SHA
    2e6627c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    34a97b2 View commit details
    Browse the repository at this point in the history