New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qutebrowser: add wrapQtAppsHook #65895
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we sure wrapGAppsHook
is needed here?
I'm assuming it was there before because it wraps XDG_DATA_DIRS
, and wrapQtAppsHook
does that so it should be unneeded.
With wrapGAppsHook, the wrapper looks like this:
Without wrapGAppsHook, the wrapper looks like this:
A brief smoke-test didn't reveal any issues at runtime, but I want to test it further before committing to removing wrapGAppsHook. |
Ah, it would be needed for |
Think this should be good, do you want to combine this with a change like #65150 @emmanuelrosa ? |
Yes, @worldofpeace I'll go ahead and apply the qutebrowser-1.7.0 commit |
This commit fixes the error: Could not find the Qt platform plugin "xcb" in "" Closes NixOS#65895
pdfjs: 1.10.100 -> 2.1.266
a2ca9e8
to
fa7716c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Runs for me in NixOS in a non-qt environment.
This commit fixes the error:
Could not find the Qt platform plugin "xcb" in ""
and upgrades qutebrowser to 1.7.0
Closes #64984
Closes #65290
Closes #65150
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @