Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tlaplusToolbox: 1.5.7 -> 1.6.0 #65948

Merged
merged 1 commit into from Aug 18, 2019
Merged

tlaplusToolbox: 1.5.7 -> 1.6.0 #65948

merged 1 commit into from Aug 18, 2019

Conversation

badmutex
Copy link
Contributor

@badmutex badmutex commented Aug 4, 2019 •
edited

Bumps to new release of TLA+ Toolbox. Addresses #65760

Main change:

  • toolbox now includes JRE so those external dependencies are no
    longer needed.

Testing:

  • nix-build -A tlaplusToolbox
  • ./result/bin/tla-toolbox
  • pdf generation
  • validation of a simple pluscal model
Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @vcunat

@badmutex
tla+ toolbox: 1.5.7 -> 1.6.0
40b53a5 
Bumps to new release of TLA+ Toolbox.

Main change:
- toolbox now includes JRE so those external dependencies are no
longer needed.

Testing:
- nix-build -A tlaplusToolbox
- ./result/bin/tla-toolbox
- pdf generation
- validation of a simple pluscal model
@badmutex badmutex changed the title tlaplustToolbox: 1.5.7 -> 1.6.0 tlaplusToolbox: 1.5.7 -> 1.6.0 Aug 4, 2019
@srhb
Copy link
Contributor

srhb commented Aug 4, 2019

I don't think it's preferable to use a bundled jre if at all avoidable. It makes it more difficult to override its behaviour etc. with regular nix approaches. Has it become more difficult to use our own?

@badmutex
Copy link
Contributor Author

badmutex commented Aug 6, 2019 •
edited

I don't think it's preferable to use a bundled jre if at all avoidable. It makes it more difficult to override its behaviour etc. with regular nix approaches

Yeah I agree.

Has it become more difficult to use our own?

Yep. The toolbox binary now looks for the packaged jre directly instead of whatever java is in PATH.

I suppose we could try to override the lookup to get the old behavior back but I haven't tried that yet.

vcunat
vcunat approved these changes Aug 18, 2019
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't feel related to this in any way, but I can't see why block the merge.

vcunat added a commit that referenced this pull request Aug 18, 2019
@vcunat
Merge #65948: tlaplusToolbox: 1.5.7 -> 1.6.0
8ed485c
@vcunat vcunat merged commit 40b53a5 into NixOS:master Aug 18, 2019
@lemmy
Copy link

lemmy commented Aug 18, 2019

FWIW: We the upstream developers decided to bundle the JRE for a reason and now consider the JRE part of our distribution, ie. might patch it in the future. We would thus recommend not to alter the lookup mechanism to use the JRE on the PATH.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@badmutex @srhb @lemmy @vcunat