New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Content download update downloads all versions, not just required/latest #7679
Comments
I believe this is actually intended behaviour OpenTTD/src/network/network_content.cpp Line 130 in 8cccb15
Checks that the ContentInfo This of course makes sense, as version numbers for content are purely informational - there's nothing enforcing any particular version scheme, or any particular order (AIAI uses the Greek alphabet, for instance) I'm not sure why loads of duplicates for BaseSets don't show up though - they do the same checks as all other content types |
I edited the issue to quote & link the docs on the Wiki. If the version is important, as stated (and as I trust it shall be), then I saw nowhere in the code anything implementing that. |
So basically what you are saying: libraries should not be upgraded independent. That sounds sane to me. So to me it seems the line @LordAro pointed out should be conditioned with: What I am not sure of, what if someone wants to download the latest version of a library. I am not sure if the |
I am unsure either. It is a bit out of the scope of this issue, though, in which I am offered version I never asked for (the system tells me I need them). It is indeed sane to allow to manage multiple versions of the same library independently, as per requirements, you might need to have multiple versions of a same library for different modules. It all boils down to how your dependencies management operates:
|
I did some more thinking on this topic, and the scenario you describe holds for all our content, not only for AIs. Scenarios can also have dependencies, heck, even NewGRFs can depend on other NewGRFs. To boil it down, what you suggest, is to track what content was manually downloaded and what came as a dependency. Upgrade the manual ones, and not the ones that came automatically. Although I get where this question comes from, I do have to wonder if the added complexity of tracking this information adds value to the game. And that brings me to the thought that the interface in general is just a bit poorly designed for the amount of downloads we offer these days. So if we would be to tackle this problem, I suggest we take a bit broader view of the problem, and fix several related issues. For example, it is nearly impossible to see what you will be downloading when you select a single piece of content. Mostly I wrote this down as this conclusion means that #7680 does not resolve the problem in a sufficient matter. I am unsure yet how we could best proceed .. a revamp of the content service part would be ideal, but I also understand that this would be a massive amount of work. |
Version of OpenTTD
1.9.2
Expected result
No upgrade offered, as the scripts library
import
docs states:Actual result
Multiple versions (with lower & higher numbers) of a downloaded package are offered as upgrades. Those versions are not required by any downloaded package.
Steps to reproduce
content_download/ai
directory &library
subdirectoryAIAI
:SuperLib v39
whill be installed as a dependency (as expected)All
SuperLib
versions will be offered as upgrades (none of them should be)The text was updated successfully, but these errors were encountered: