Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cantata: use Qt mkDerivation #66088

Closed
wants to merge 1 commit into from
Closed

cantata: use Qt mkDerivation #66088

wants to merge 1 commit into from

Conversation

sikmir
Copy link
Member

@sikmir sikmir commented Aug 5, 2019

Motivation for this change

Fix runtime error:

qt.qpa.plugin: Could not find the Qt platform plugin "xcb" in ""
This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @Fuuzetsu, @peterhoeg

@ofborg ofborg bot requested review from Fuuzetsu and peterhoeg August 5, 2019 17:03
worldofpeace
worldofpeace approved these changes Aug 5, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me 👍

Thanks for fixing this @sikmir.

@worldofpeace
Copy link
Contributor

Merged in 9a9dc03

@sikmir sikmir deleted the cantata branch August 5, 2019 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

@Fuuzetsu Fuuzetsu Awaiting requested review from Fuuzetsu

@peterhoeg peterhoeg Awaiting requested review from peterhoeg

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sikmir @worldofpeace