Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitkraken: 6.0.0 -> 6.0.1 #65924

Merged
merged 3 commits into from
Aug 10, 2019
Merged

gitkraken: 6.0.0 -> 6.0.1 #65924

merged 3 commits into from
Aug 10, 2019
+5 −2

Conversation

r-ryantm
Copy link
Contributor

@r-ryantm r-ryantm commented Aug 4, 2019

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/gitkraken/versions.

meta.description for gitkraken is: '"The downright luxurious and most popular Git client for Windows, Mac & Linux"'.

meta.homepage for gitkraken is: '"https://www.gitkraken.com/"

Checks done (click to expand)
Rebuild report (if merged into master) (click to expand)

3 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
gitkraken

Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/n12lv2xgs9nc1hcvx6744rfn0xp8lh0i-gitkraken-6.0.1 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)

Or, build yourself:

nix-build -A gitkraken https://github.com/r-ryantm/nixpkgs/archive/8123b2d11e89cca22c046fdd0acd9956554676c7.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/n12lv2xgs9nc1hcvx6744rfn0xp8lh0i-gitkraken-6.0.1
ls -la /nix/store/n12lv2xgs9nc1hcvx6744rfn0xp8lh0i-gitkraken-6.0.1/bin

cc @xNWDD for testing.

@r-ryantm
gitkraken: 6.0.0 -> 6.0.1
8123b2d 
Semi-automatic update generated by
https://github.com/ryantm/nixpkgs-update tools. This update was made
based on information from
https://repology.org/metapackage/gitkraken/versions
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Aug 4, 2019
@ysndr
Copy link
Member

ysndr commented Aug 4, 2019

Package builds but won't start up (stuck at spinning squid animation window)
Sadly no log files ore suspicious errors were written..

@worldofpeace
Copy link
Contributor

worldofpeace commented Aug 5, 2019 •
edited
Loading

ping @evanjs @megheaiulian
(perhaps consider adding yourselves to meta.maintainers)

@evanjs
Copy link
Member

evanjs commented Aug 5, 2019

Package builds but won't start up (stuck at spinning squid animation window)
Sadly no log files ore suspicious errors were written..

Encountered this when trying to bump it and I have no clue what's going on 😵
ldd shows nothing obvious missing, and strace isn't very telling.

@worldofpeace
Copy link
Contributor

To start, it looks like certain binaries need openssl_1_1 and e2fsprogs.
From there I think something is up with the native modules.

@evanjs
Copy link
Member

evanjs commented Aug 5, 2019 •
edited
Loading

To start, it looks like certain binaries need openssl_1_1 and e2fsprogs.
From there I think something is up with the native modules.

Ah-ha!
Thanks for that, I did not realize I would need to check the node modules as well.
In this case, adding e2fsprogs and krb5 seemed to do the trick.

Edit: diff for clarity:

--- a/pkgs/applications/version-management/gitkraken/default.nix
+++ b/pkgs/applications/version-management/gitkraken/default.nix
@@ -3,6 +3,7 @@
 , libX11, libXi, libxcb, libXext, libXcursor, glib, libXScrnSaver, libxkbfile, libXtst
 , nss, nspr, cups, fetchurl, expat, gdk_pixbuf, libXdamage, libXrandr, dbus
 , dpkg, makeDesktopItem, openssl, wrapGAppsHook, hicolor-icon-theme, at-spi2-atk, libuuid
+, e2fsprogs, krb5
 }:
 
 with stdenv.lib;
@@ -55,6 +56,8 @@ stdenv.mkDerivation rec {
     openssl
     at-spi2-atk
     libuuid
+    e2fsprogs
+    krb5
   ];
 
   desktopItem = makeDesktopItem {

mmahut
mmahut approved these changes Aug 9, 2019
View reviewed changes
Copy link
Member

@mmahut mmahut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @evanjs, the package now works fine for me.

@worldofpeace
Copy link
Contributor

This doesn't appear to be the latest version

@mmahut
Copy link
Member

mmahut commented Aug 9, 2019

This doesn't appear to be the latest version

Good catch, the latest was released today. We are so cutting edge :)

worldofpeace
worldofpeace approved these changes Aug 9, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, someone with an account should test it though.

@evanjs
Copy link
Member

evanjs commented Aug 9, 2019 •
edited
Loading

Works for me (logged in with my GK account). Tried switching between profiles, basic git functionality, etc.

@ryantm ryantm merged commit 07ce48c into NixOS:master Aug 10, 2019
@r-ryantm r-ryantm deleted the auto-update/gitkraken branch August 17, 2019 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmahut mmahut

@worldofpeace worldofpeace

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@r-ryantm @ysndr @worldofpeace @evanjs @mmahut @ryantm