Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openjpeg: disable tests for aarch64 linux #65926

Merged
merged 1 commit into from Aug 4, 2019
Merged

openjpeg: disable tests for aarch64 linux #65926

merged 1 commit into from Aug 4, 2019

Conversation

worldofpeace
Copy link
Contributor

@worldofpeace worldofpeace commented Aug 4, 2019 •
edited

Fails on hydra https://hydra.nixos.org/build/98332124

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@worldofpeace
Copy link
Contributor Author

I don't see a rebuild on x86_64-linux https://github.com/NixOS/nixpkgs/pull/65926/checks?check_run_id=184880075 so should be good to master.

@worldofpeace worldofpeace merged commit 7ed3bd4 into NixOS:master Aug 4, 2019
@worldofpeace worldofpeace deleted the openjpeg/disable-tests-aarch64 branch August 4, 2019 10:55
@timokau
Copy link
Member

timokau commented Aug 8, 2019

The log looks like the build is actually failing and the tests only fail because the tested binaries were not created. Am I missing something? Why is it reasonable to disable tests here?

@worldofpeace
Copy link
Contributor Author

It was reasonable to disable the tests because they always failed on aarch64-linux since they were enabled.

because the tested binaries were not created.

Care to explain what a tested binary is in this context?
This seems to build fine again

@timokau
Copy link
Member

timokau commented Aug 8, 2019

Care to explain what a tested binary is in this context?

Well first the log says

Error(s) when building project

And then

Unable to find executable: /build/source/build/build/bin/opj_compress

So to me it sounds like the openjpg binaries failed to compile and the tests failed because the binaries were not present.

@worldofpeace
Copy link
Contributor Author

I've inspected the output by realizing the store path in the hydra link, and I can see the binaries, and I ran one of them on a aarch64 machine.

@timokau
Copy link
Member

timokau commented Aug 8, 2019

Curious. I can't find any details on the supposed build errors either 🤷‍♂️

Well at least it seems to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etu etu etu approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@worldofpeace @timokau @etu