Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dogecoin: 1.10.0 -> 1.14.1 #66071

Merged
merged 1 commit into from Aug 12, 2019
Merged

dogecoin: 1.10.0 -> 1.14.1 #66071

merged 1 commit into from Aug 12, 2019

Conversation

angristan
Copy link
Member

@angristan angristan commented Aug 5, 2019 •
edited

Motivation for this change

https://github.com/dogecoin/dogecoin/releases

Things done

update-source-version altcoins.dogecoin 1.14.1 + add libevent

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @edwtjo @offline @AndersonTorres

jonringer
jonringer approved these changes Aug 5, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
most (didn't test all) of the binaries seem to work.

@mmahut
Copy link
Member

mmahut commented Aug 12, 2019

@GrahamcOfBorg build altcoins.dogecoin

@mmahut mmahut merged commit 9a86619 into NixOS:master Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@offlinehacker offlinehacker Awaiting requested review from offlinehacker

@edwtjo edwtjo Awaiting requested review from edwtjo

@AndersonTorres AndersonTorres Awaiting requested review from AndersonTorres

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@angristan @mmahut @jonringer