Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pytrends: init at 4.6.0 #66069

Merged
merged 1 commit into from Aug 6, 2019
Merged

pythonPackages.pytrends: init at 4.6.0 #66069

merged 1 commit into from Aug 6, 2019

Conversation

mmahut
Copy link
Member

@mmahut mmahut commented Aug 5, 2019

Motivation for this change

pythonPackages.pytrends: init at 4.6.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mmahut mmahut requested a review from FRidh as a code owner August 5, 2019 13:18
@mmahut
Copy link
Member Author

mmahut commented Aug 5, 2019

@GrahamcOfBorg build python27Packages.pytrends python37Packages.pytrends

@mmahut
Copy link
Member Author

mmahut commented Aug 5, 2019

@GrahamcOfBorg eval

srhb
srhb requested changes Aug 5, 2019
View reviewed changes
Copy link
Contributor

@srhb srhb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Figured you've been staring at the eval issue. Been there, done that. 😀

pkgs/development/python-modules/pytrends/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/pytrends/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/pytrends/default.nix Outdated Show resolved Hide resolved
@mmahut
Copy link
Member Author

mmahut commented Aug 5, 2019

@srhb thank you, rebased.

@srhb srhb merged commit 2b49f9c into NixOS:master Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srhb srhb srhb approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mmahut @srhb