Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typora: 0.9.72 -> 0.9.73 #65915

Merged
merged 1 commit into from Aug 4, 2019
Merged

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

Determined it uses electron_5 by looking at the version file in the archive.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ysndr
Copy link
Member

ysndr commented Aug 4, 2019

Would not open files if not given as command line argument. This has been an issue before so this might not be a consequence of this update, sadly updating to the newer electron didn't help here.

Also the program shows errors regarding mismatching node versions hindering it from auto reloading files.

image

@worldofpeace
Copy link
Contributor Author

I've tested this with #65916 and that issue was gone.
Can you try that @ysndr?

@ysndr
Copy link
Member

ysndr commented Aug 4, 2019

Yes that seems to work. Fixes both the error message and opening/navigating of files and folders.
maybe other issues with typora will be fixed due to this as well but that needs more usage than I can currently afford.
Anyway I found no more obvious issues with this PR.
seems good to go @worldofpeace

@worldofpeace
Copy link
Contributor Author

Thanks @ysndr , merging.

@worldofpeace worldofpeace merged commit 57d6508 into NixOS:master Aug 4, 2019
@worldofpeace worldofpeace deleted the typora-update branch August 4, 2019 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants