Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wt3: 3.3.11 -> 3.4.0, wt4: 4.0.5 -> 4.1.0 #65944

Merged
merged 2 commits into from Aug 5, 2019
Merged

Conversation

WilliButz
Copy link
Member

Motivation for this change

New releases for wt3 and wt4

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested all pkgs that depend on this change
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ma27
Copy link
Member

Ma27 commented Aug 4, 2019

../src/include/../common/classes/fb_atomic.h:521:2: error: #error AtomicCounter: implement appropriate code for your platform!

(see the aarch-64 build at https://logs.nix.ci/?key=nixos/nixpkgs.65944&attempt_id=771fda62-66c0-48ae-8a28-f9dfafe2a48f)

Unless there's somewhere a pending, unreleased fix, I'd exclude aarch64 for now, right?

Copy link
Member

@Ma27 Ma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build and tested locally. The change seems fine, however we should discuss what to do with aarch64 before merging this :)

@WilliButz
Copy link
Member Author

Unless there's somewhere a pending, unreleased fix, I'd exclude aarch64 for now, right?

Do you mean excluding it from the supported platforms? If so, I think we shouldn't do that because it's a transitive build error:

builder for '/nix/store/bdbdr1nrifsx4pgnx72ydgrf8dyai8v6-firebird-2.5.7.27050-0.drv' failed with exit code 2
cannot build derivation '/nix/store/98ryhrfm8zz08bqs7jxmwim0c395fi9p-wt-3.4.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/4i58dmnkj3jl8hl4iqqisp5pps090d34-wt-4.1.0.drv': 1 dependencies couldn't be built

@Ma27
Copy link
Member

Ma27 commented Aug 5, 2019

Ouch, I forgot that (in constrast to e.g. Hydra) all build outputs are written to a single log...

According to their installation page (https://www.webtoolkit.eu/wt/doc/reference/html/InstallationUnix.html) it doesn't seem as they miss the support of several platforms. Let's wait until firebird gets fixed on aarch64 👍

@Ma27 Ma27 merged commit b3f61cf into NixOS:master Aug 5, 2019
@WilliButz WilliButz deleted the update-wt branch August 5, 2019 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants