New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Surf display kiosk session #65860
Surf display kiosk session #65860
Conversation
@GrahamcOfBorg eval |
5954211
to
4fb4d5d
Compare
@GrahamcOfBorg build surf-display Building again now when openjpeg should be fixed on master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good, left some comments to make it ideal.
Note I haven't verified the buildInputs
yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noticed one small thing.
fb35490
to
51aefa7
Compare
Currently everything works perfectly fine except for the configuration of the session. I will have a look at this soon. I know how to solve it. |
51aefa7
to
c9a9e7a
Compare
And now the config works properly, I just imported the template config and overwrote the variables that I implemented support for in the module. |
85226d4
to
7e137bc
Compare
2eaac66
to
b4f3e4a
Compare
b4f3e4a
to
9792422
Compare
9792422
to
8408232
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh I forgot two from last time 😄
After this your pr should be good for merge if it works for you.
8408232
to
c8fda64
Compare
c8fda64
to
792da0c
Compare
@worldofpeace Still works perfectly fine locally 👍 |
It had weird effects, breaking the metrics job.
How can this be used? This simple configuration drops me into fluxbox and not surf-display { pkgs, ... }:
{
users.users.user = {
isNormalUser = true;
extraGroups = [ "wheel" ];
initialPassword = "";
home = "/home/user";
};
environment.systemPackages = with pkgs; [
alacritty
];
programs.git.enable = true;
services = {
openssh.enable = true;
spice-vdagentd.enable = true;
qemuGuest.enable = true;
xserver = {
enable = true;
desktopManager.surf-display.enable = false;
windowManager.fluxbox.enable = true;
displayManager = {
#defaultSession = "surf-display";
autoLogin.enable = true;
autoLogin.user = "user";
};
};
};
} |
@michaelCTS Hello, first of all I want to note that 4 year old pull requests aren't a support forum. For support please turn to support channels such as Matrix or Discourse mentioned here: https://nixos.org/community/ Then second of all, if you read what you have written in your config it should be fairly obvious why you get fluxbox and not surf-display since... you have fluxbox enabled and surf-display disabled. I personally haven't had the need for surf-display for a couple of years so I'm a bit unsure of the current state. But I would expect that it works. |
Motivation for this change
Adds surf-display as a package which is kiosk browser session using the surf browser.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)cc @talyz @adisbladis @aanderse