Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Surf display kiosk session #65860

Merged
merged 2 commits into from Aug 5, 2019
Merged

Conversation

etu
Copy link
Contributor

@etu etu commented Aug 3, 2019

Motivation for this change

Adds surf-display as a package which is kiosk browser session using the surf browser.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @talyz @adisbladis @aanderse

@etu
Copy link
Contributor Author

etu commented Aug 3, 2019

@GrahamcOfBorg eval
@GrahamcOfBorg build surf-display

@etu
Copy link
Contributor Author

etu commented Aug 4, 2019

@GrahamcOfBorg build surf-display

Building again now when openjpeg should be fixed on master

Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, left some comments to make it ideal.

Note I haven't verified the buildInputs yet.

pkgs/desktops/surf-display/default.nix Outdated Show resolved Hide resolved
pkgs/desktops/surf-display/default.nix Outdated Show resolved Hide resolved
pkgs/desktops/surf-display/default.nix Outdated Show resolved Hide resolved
pkgs/desktops/surf-display/default.nix Outdated Show resolved Hide resolved
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed one small thing.

@etu etu force-pushed the surf-display-kiosk-session branch from fb35490 to 51aefa7 Compare August 4, 2019 11:50
@etu
Copy link
Contributor Author

etu commented Aug 4, 2019

Currently everything works perfectly fine except for the configuration of the session. I will have a look at this soon. I know how to solve it.

@etu etu force-pushed the surf-display-kiosk-session branch from 51aefa7 to c9a9e7a Compare August 4, 2019 13:05
@etu
Copy link
Contributor Author

etu commented Aug 4, 2019

And now the config works properly, I just imported the template config and overwrote the variables that I implemented support for in the module.

@etu etu force-pushed the surf-display-kiosk-session branch 3 times, most recently from 85226d4 to 7e137bc Compare August 4, 2019 14:37
@etu etu force-pushed the surf-display-kiosk-session branch 2 times, most recently from 2eaac66 to b4f3e4a Compare August 4, 2019 14:56
@etu etu force-pushed the surf-display-kiosk-session branch from b4f3e4a to 9792422 Compare August 4, 2019 20:52
@etu etu force-pushed the surf-display-kiosk-session branch from 9792422 to 8408232 Compare August 5, 2019 09:22
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh I forgot two from last time 😄

After this your pr should be good for merge if it works for you.

@etu etu force-pushed the surf-display-kiosk-session branch from 8408232 to c8fda64 Compare August 5, 2019 15:46
@etu etu force-pushed the surf-display-kiosk-session branch from c8fda64 to 792da0c Compare August 5, 2019 15:50
@etu
Copy link
Contributor Author

etu commented Aug 5, 2019

@worldofpeace Still works perfectly fine locally 👍

@worldofpeace worldofpeace merged commit 7a53b1c into NixOS:master Aug 5, 2019
@etu etu deleted the surf-display-kiosk-session branch August 6, 2019 05:21
vcunat added a commit that referenced this pull request Aug 8, 2019
It had weird effects, breaking the metrics job.
@michaelCTS
Copy link
Contributor

How can this be used?

This simple configuration drops me into fluxbox and not surf-display

{ pkgs, ... }:                                   
{                                                
                                                 
  users.users.user = {                           
    isNormalUser = true;                         
    extraGroups = [ "wheel" ];                   
    initialPassword = "";                        
    home = "/home/user";                         
  };                                             
                                                 
                                                 
  environment.systemPackages = with pkgs; [      
    alacritty                                    
  ];                                             
                                                 
  programs.git.enable = true;                    
  services = {                                   
    openssh.enable = true;                       
    spice-vdagentd.enable = true;                
    qemuGuest.enable = true;                     
                                                 
    xserver = {                                  
      enable = true;                             
                                                 
      desktopManager.surf-display.enable = false;
      windowManager.fluxbox.enable = true;       
      displayManager = {                         
          #defaultSession = "surf-display";      
          autoLogin.enable = true;               
          autoLogin.user = "user";               
      };                                         
    };                                           
  };                                                                                           
}                                                

@etu
Copy link
Contributor Author

etu commented Sep 16, 2023

@michaelCTS Hello, first of all I want to note that 4 year old pull requests aren't a support forum. For support please turn to support channels such as Matrix or Discourse mentioned here: https://nixos.org/community/

Then second of all, if you read what you have written in your config it should be fairly obvious why you get fluxbox and not surf-display since... you have fluxbox enabled and surf-display disabled.

I personally haven't had the need for surf-display for a couple of years so I'm a bit unsure of the current state. But I would expect that it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants