Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.cairocffi: correct gdk-pixbuf substitution #65864

Merged
merged 1 commit into from Aug 5, 2019
Merged

python3Packages.cairocffi: correct gdk-pixbuf substitution #65864

merged 1 commit into from Aug 5, 2019

Conversation

eadwu
Copy link
Member

@eadwu eadwu commented Aug 3, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@eadwu eadwu requested a review from FRidh as a code owner August 3, 2019 19:07
@eadwu eadwu mentioned this pull request Aug 3, 2019
Merged
10 tasks
worldofpeace
worldofpeace suggested changes Aug 3, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about the 0.9 version of the patch?

@worldofpeace
Copy link
Contributor

And can make the commit msg's correct gdk-pixbuf substitution or something like that?

@eadwu eadwu force-pushed the python3Packages.cairocffi/gdk_pixbuf branch from ab78c79 to b7ecab3 Compare August 3, 2019 19:57
@worldofpeace worldofpeace changed the title python3Packages.cairocffi: gdk-pixbuf -> gdk_pixbuf python3Packages.cairocffi: correct gdk-pixbuf substitution Aug 5, 2019
worldofpeace
worldofpeace approved these changes Aug 5, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built the packages fine 👍

@worldofpeace worldofpeace merged commit 4e79568 into NixOS:master Aug 5, 2019
@eadwu eadwu deleted the python3Packages.cairocffi/gdk_pixbuf branch November 17, 2020 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eadwu @worldofpeace