Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zeal: fix to be compatible with wrapQtAppsHook #66044

Closed
wants to merge 1 commit into from
Closed

zeal: fix to be compatible with wrapQtAppsHook #66044

wants to merge 1 commit into from

Conversation

vorot93
Copy link
Contributor

@vorot93 vorot93 commented Aug 5, 2019 •
edited

Tested locally using qt5.callPackage.

ref #65399

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from peterhoeg August 5, 2019 10:01
@worldofpeace
Copy link
Contributor

Merged to master in d21d654

@worldofpeace
Copy link
Contributor

Thanks @vorot93

@peterhoeg
Copy link
Member

@worldofpeace, how about name -> pname ?

@vorot93 vorot93 deleted the patch-1 branch September 4, 2019 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterhoeg peterhoeg Awaiting requested review from peterhoeg

Assignees
No one assigned
Labels
8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vorot93 @worldofpeace @peterhoeg