Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19.03] Backport mtxclient and nheko to 19.03 #65982

Closed
wants to merge 1 commit into from
Closed

[19.03] Backport mtxclient and nheko to 19.03 #65982

wants to merge 1 commit into from
+15 −12

Conversation

balsoft
Copy link
Member

@balsoft balsoft commented Aug 4, 2019

Motivation for this change

nheko 0.6.3 from nixos-19.03 channel crashes when sending messages to V3 matrix rooms (most rooms on modern servers) thus rendering it useless. This backport fixes it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @fpletz @Ekleog

Sorry, something went wrong.

@Ekleog
nheko: 0.6.3 -> 0.6.4, mtxclient: 0.2.0 -> 0.2.1 (backport from unsta…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
83b7f8d 
…ble)
@ofborg ofborg bot requested review from fpletz and Ekleog August 4, 2019 21:52
fpletz
fpletz requested changes Aug 6, 2019
View reviewed changes
Copy link
Member

@fpletz fpletz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We usually cherry-pick -x individual commits instead of squashing them into one. Is there are reason for doing it like this here?

@balsoft
Copy link
Member Author

balsoft commented Aug 6, 2019

No particular reason, I'm sometimes very bad at git :)

@veprbl veprbl changed the title Backport mtxclient and nheko to 19.03 [19.03] Backport mtxclient and nheko to 19.03 Oct 25, 2019
@veprbl
Copy link
Member

veprbl commented Oct 25, 2019

The 19.09 is out. Is this still relevant?

@balsoft balsoft closed this Oct 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz

@Ekleog Ekleog

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@balsoft @veprbl @fpletz @Ekleog