Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

taisei: init at 1.3 #66003

Merged
merged 1 commit into from May 26, 2020
Merged

taisei: init at 1.3 #66003

merged 1 commit into from May 26, 2020

Conversation

lambda-11235
Copy link
Contributor

Motivation for this change

Add package for Taisei, an open source game based off of the Touhou series.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@lambda-11235
Copy link
Contributor Author

One issue I ran into with this package is that it does not properly link with the bundled static libraries if link time optimizations are enabled (it complains of unrecognized symbols that are clearly present). I'm not sure if this is an issue on the Nix side or upstream. Any input would be appreciated.

@lambda-11235
Copy link
Contributor Author

1.3.1 is out, but #68767 must be dealt with before it can be made to compile.

@Lassulus Lassulus merged commit dcb996d into NixOS:master May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants