New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
yder: 1.4.6 -> 1.4.7 #65966
yder: 1.4.6 -> 1.4.7 #65966
Conversation
@GrahamcOfBorg build orcania yder |
Ruh-oh, looks like it failed on Darwin. |
target_include_directories(${t} PUBLIC ${TST_DIR}) | ||
target_link_libraries(${t} PUBLIC ${LIBS}) | ||
add_test(NAME ${t} | ||
- WORKING_DIRECTORY ${TST_DIR} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this line of my patch didn't make it upstream
Oh no :( |
11c75d2
to
77b4e4b
Compare
@GrahamcOfBorg build orcania yder |
Nice, it works! |
Motivation for this change
Now we don't need the custom patch anymore to make it build on Darwin. Please someone test or have @GrahamcOfBorg test it :)
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)