New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rust-cbindgen: 0.8.7 -> 0.9.0 #65856
Conversation
thanks a nix-review on this failed with:
|
With Firefox 68.0.2 (both esr and non-esr) it works fine. I also managed to build the tor browser after upgrading rust-cbindgen. |
I'm getting a hash failure downloading the cargo deps:
Any idea what's going on? I thought packages from Here's my full build log
|
@wizeman that is probably due to some cargo-vendor changes yet again.. It has a habit to change hashes between releases. Can you tell me which nixpkgs revision you are on? In the long run we should fix that up... |
I hope that the output will be more reliable now that |
I'm on revision 609fe21, a recent commit from the stable |
Are you also on x86_64-linux? I fail to reproduce the error :/ |
hmm, i didn't do a port to stable, so this shouldn't be affecting you. The only other thing i can think of is that you may have an overlay which is effecting it. |
@jonringer Maybe you didn't but it seems that someone did. See https://github.com/NixOS/nixpkgs/blob/release-19.03/pkgs/development/tools/rust/cbindgen/default.nix and commit f8bcf67. @andir Yes, I'm on x86_64-linux. Probably you can't reproduce it because your machine already has the derivation cached. This is also the reason why NixOS's Hydra instance usually doesn't notice hash changes. Try changing the Cargo vendor doesn't seem to have changed recently so maybe some version of a dependency was yanked from If anyone could post a build log of the dependencies being fetched perhaps we could compare dependency versions to see if one of them has changed (due to yanking). |
Motivation for this change
fixing packages that failed to build in rryantm logs.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @jtojnar @andir