Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disper: 0.3.1 -> 0.3.1.1 #65855

Merged
merged 1 commit into from Aug 5, 2019
Merged

disper: 0.3.1 -> 0.3.1.1 #65855

merged 1 commit into from Aug 5, 2019

Conversation

jonringer
Copy link
Contributor

Motivation for this change

was going through rryantm logs, looking for failures.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

WilliButz
WilliButz requested changes Aug 4, 2019
View reviewed changes
Copy link
Member

@WilliButz WilliButz left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed weird comment

pkgs/tools/misc/disper/default.nix Outdated Show resolved Hide resolved
WilliButz
WilliButz approved these changes Aug 5, 2019
View reviewed changes
Copy link
Member

@WilliButz WilliButz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@WilliButz WilliButz merged commit c4d3c5e into NixOS:master Aug 5, 2019
@jonringer jonringer deleted the fix-disper branch August 8, 2019 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilliButz WilliButz WilliButz approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @WilliButz