emacs-packages: Clean up redundant packages & allow overriding attrsets #65874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adisbladis
force-pushed
the
emacs-melpa-overrides
branch
from
216deaf
to
36cc11c
Compare
adisbladis
force-pushed
the
emacs-melpa-overrides
branch
from
36cc11c
to
8a5985a
Compare
adisbladis
force-pushed
the
emacs-melpa-overrides
branch
2 times, most recently
from
3e2d64e
to
0695e2a
Compare
adisbladis
changed the title
adisbladis
force-pushed
the
emacs-melpa-overrides
branch
4 times, most recently
from
83b3da8
to
85e32c1
Compare
adisbladis
changed the title
adisbladis
force-pushed
the
emacs-melpa-overrides
branch
from
4c1ae64
to
37567f8
Compare
adisbladis
changed the title
adisbladis
changed the title
adisbladis
changed the title
adisbladis
force-pushed
the
emacs-melpa-overrides
branch
from
dac344e
to
0c79966
Compare
|
I will merge these changes within the next 24 hours (probably way sooner) if there are no objections. |
Previously working directory was important
This enables using the melpa json generator in an overlay
Use autogenerated modules from melpa instead
Use autogenerated modules from melpa instead
Use autogenerated modules from melpa instead
It's now merged upstream in evil-mode
Use melpa generated package instead
It's in the melpa generated package `circe`
It's in the melpa generated package `circe`
Use melpa generated package instead
It's in the melpa generated package `circe`
Use autogenerated package from melpa
Use generated melpa package instead
Use auto-generated melpa package
Use auto-generated melpa package
Use auto-generated melpa package
This allows overriding the individual package sets composing
emacsPackagesNg.
Example:
```
myEmacsPackages = emacsPackagesNg.override {
melpaPackages = {};
};
```
And let emacs-packages.nix only aggregate the attrsets
adisbladis
force-pushed
the
emacs-melpa-overrides
branch
from
0c79966
to
be74dec
Compare
This was referenced Aug 7, 2019
Closed
|
@adisbladis 978b346 broke irony :( |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I'm creating an auto updating emacs overlay based on https://github.com/adisbladis/exwm-overlay which will contain all our auto-generated emacs package sets and need the ability to override the loading of these.
Things done
With these changes I can generate a new
melpaPackagesfrom my locally generated json like this:And then use it to create a new emacsPackagesNg set:
or for a more complete example see the
melpabranch in my overlay repo: nix-community/emacs-overlay@f7edeaaAlso the updater script can now be called from anywhere and the output JSON will be in current working directory.
While i do think this method is a bit crude it was by far the easiest way I could come up with to achieve what I wanted.
I also started cleaning up a bit of redundant packages that come autogenerated from melpa that we don't need explicit derivations for.
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @gridaphobe @oxij @talyz @mdorman
edit: The scope of this PR grew a bit as I went along and cleaned up redundant packages. If need be I can split it into 2 PRs.
If you'd like to join in on this effort or if you're just interested in the emacs packaging in nixpkgs I've created
#nixos-emacson freenode.