New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mono: remove outdated workaround; pythonPackages.pythonnet: 2.3.0 -> 2.4.0 #65875
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pythonnet part seems fine.
Would it be a good idea to split the PR more? Each commit its own PR? |
@@ -20,9 +22,6 @@ stdenv.mkDerivation rec { | |||
|
|||
NIX_LDFLAGS = if stdenv.isDarwin then "" else "-lgcc_s" ; | |||
|
|||
# To overcome the bug https://bugzilla.novell.com/show_bug.cgi?id=644723 | |||
dontDisableStatic = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Won't this impact previous (<6) version of mono?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did nix-review and all compiled and what I tried to run worked well, or at least no worse than before. Notice the bugzilla is quite ancient. I removed it based on suggestion in #58797 (comment).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok then.
Seems like fine job as a whole. If the above about |
Motivation for this change
New major release of Mono. Fix previously broken pythonPackages.pythonnet. The release notes for 2.4.0 newly mention support for Python 3.7.
The following packages are still failing to build in nix-review, but they were failing even before this change and I don't know how to fix them quickly.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @thoughtpolice @obadz @vrthra @jraygauthier