Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] pgcli: 2.0.2 -> 2.1.1 #66037

Closed
wants to merge 2 commits into from
Closed

[WIP] pgcli: 2.0.2 -> 2.1.1 #66037

wants to merge 2 commits into from

Conversation

edef1c
Copy link
Member

@edef1c edef1c commented Aug 5, 2019

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Currently, the tests are breaking, and I'm not quite sure why yet.

=================================== FAILURES ===================================
____________________________ test_multihost_db_uri _____________________________

tmpdir = local('/build/pytest-of-nixbld/pytest-0/test_multihost_db_uri0')

    def test_multihost_db_uri(tmpdir):
        with mock.patch.object(PGCli, "connect") as mock_connect:
            cli = PGCli(pgclirc_file=str(tmpdir.join("rcfile")))
            cli.connect_uri(
                "postgres://bar:foo@baz1.com:2543,baz2.com:2543,baz3.com:2543/testdb"
            )
        mock_connect.assert_called_with(
            database="testdb",
            host="baz1.com,baz2.com,baz3.com",
            user="bar",
            passwd="foo",
>           port="2543,2543,2543",
        )

tests/test_main.py:326:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
/nix/store/zi1b5igc0ajfhj0z4mbvysc9aizf8ky1-python3.7-mock-2.0.0/lib/python3.7/site-packages/mock/mock.py:937: in assert_called_with
    six.raise_from(AssertionError(_error_message(cause)), cause)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

value = None, from_value = None

>   ???
E   AssertionError: Expected call: connect(database='testdb', host='baz1.com,baz2.com,baz3.com', passwd='foo', port='2543,2543,2543', user='bar')
E   Actual call: connect(database='testdb', host='baz1.com', passwd='foo', port='2543,baz2.com:2543,baz3.com:2543', user='bar')

<string>:3: AssertionError

@edef1c edef1c requested a review from FRidh as a code owner August 5, 2019 08:44
@edef1c edef1c closed this Aug 5, 2019
@edef1c edef1c deleted the pgcli-2.1.1 branch August 5, 2019 08:46
@edef1c
Copy link
Member Author

edef1c commented Aug 5, 2019

(didn't mean to push to a branch on this repo, but hub pull-request is treacherous)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant