Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.boltztrap2: 19.1.1 -> 19.7.3 #66035

Merged
merged 1 commit into from Aug 19, 2019
Merged

python3Packages.boltztrap2: 19.1.1 -> 19.7.3 #66035

merged 1 commit into from Aug 19, 2019

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Aug 5, 2019 •
edited

Motivation for this change

noticed it was broken on master while reviewing #66023

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

[3 built, 4 copied (19.1 MiB), 3.7 MiB DL]
https://github.com/NixOS/nixpkgs/pull/66035
1 package were build:
python37Packages.boltztrap2

./results/python37Packages.boltztrap2/bin/btp2 --help
you can install pyfftw to get better FFT performance
vtk not found. The 'fermisurface' command will be disabled
usage: btp2 [-h] [-v] [-n NWORKERS] [-V] command [options] ... ...

bunch of scientific libraries, large closure is expected.

$ nix path-info -Sh ./results/python37Packages.boltztrap2
/nix/store/l2cyqahdg6m9z8j4lmlzy1dwlkf3k7mf-python3.7-BoltzTraP2-19.7.3  551.6M

@jonringer jonringer requested a review from FRidh as a code owner August 5, 2019 08:22
@jonringer jonringer mentioned this pull request Aug 5, 2019
Merged
10 tasks
@jonringer
Copy link
Contributor Author

@FRidh applied changes :)

@FRidh FRidh merged commit 72b1553 into NixOS:master Aug 19, 2019
@jonringer jonringer deleted the bump-boltz branch August 19, 2019 17:54
@jonringer jonringer mentioned this pull request Aug 19, 2019
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh left review comments

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @FRidh