Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.ase: 3.17.0 -> 3.18.0 #66038

Merged
merged 2 commits into from Aug 8, 2019
Merged

python3Packages.ase: 3.17.0 -> 3.18.0 #66038

merged 2 commits into from Aug 8, 2019

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Aug 5, 2019 •
edited by ryantm

Motivation for this change

noticed the python2 build was broken in #66023

froze python2 version at 3.17, as 3.18 dropped support of python<3.5

the boltztrap2 package is being fixed here: #66035
and scikit-learn is broken on master (and I don't want to touch that), so i can't fix dtffit package.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @costrouc

closes #66023

@jonringer jonringer requested a review from FRidh as a code owner August 5, 2019 08:45
@jonringer jonringer mentioned this pull request Aug 5, 2019
Closed
@jonringer jonringer changed the title Bump ase python3Packages.ase: 3.17.0 -> 3.18.0 Aug 5, 2019
@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build python2Packages.ase python3Packages.ase

@mmahut
Copy link
Member

mmahut commented Aug 8, 2019

@GrahamcOfBorg build pythonPackages.ase python3Packages.ase

@mmahut mmahut merged commit a0d54b2 into NixOS:master Aug 8, 2019
@jonringer jonringer deleted the bump-ase branch August 8, 2019 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @mmahut