Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ctrtool update #66079

Merged
merged 1 commit into from Aug 10, 2019
Merged

Ctrtool update #66079

merged 1 commit into from Aug 10, 2019

Conversation

marius851000
Copy link
Contributor

Motivation for this change

ctrtool was updated yesterday

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

aanderse
aanderse requested changes Aug 6, 2019
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • please change commit message to ctrtool: 0.15 -> 0.16 as per CONTRIBUTING.md
  • please drop the extra dolphin-emu commit

pkgs/tools/archivers/ctrtool/default.nix Show resolved Hide resolved
marius851000
marius851000 commented Aug 10, 2019
View reviewed changes
Copy link
Contributor Author

@marius851000 marius851000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's done

pkgs/tools/archivers/ctrtool/default.nix Show resolved Hide resolved
@aanderse
Copy link
Member

@GrahamcOfBorg build ctrtool

@aanderse aanderse merged commit 0f91a1f into NixOS:master Aug 10, 2019
@aanderse
Copy link
Member

@marius851000 thanks! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanderse aanderse aanderse approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marius851000 @aanderse