telepresence: 0.93 -> 0.101 #66054
Merged
telepresence: 0.93 -> 0.101 #66054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
offlinehacker
force-pushed
the
pkgs/telepresence/fix
branch
from
61bd563
to
c6038ab
Compare
Mic92
reviewed
Aug 5, 2019
offlinehacker
force-pushed
the
pkgs/telepresence/fix
branch
from
c6038ab
to
7bd3380
Compare
Mic92
reviewed
Aug 12, 2019
| }; | ||
|
|
||
| buildInputs = p.buildInputs ++ [ git ]; | ||
| nativeBuildInputs = p.nativeBuildInputs ++ [ git ]; |
There was a problem hiding this comment.
how about in that case?
Suggested change
| nativeBuildInputs = p.nativeBuildInputs ++ [ git ]; |
There was a problem hiding this comment.
without this builder for sshuttle says:
LookupError: setuptools-scm was unable to detect version for '/build/sshuttle-32226ff'.
having git as nativeBuildInput resolves that
There was a problem hiding this comment.
setuptools_scm als supports the environment variable SETUPTOOLS_SCM_PRETEND_VERSION.
example:
offlinehacker
force-pushed
the
pkgs/telepresence/fix
branch
from
7bd3380
to
02a1182
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @matejc @uroshercog