Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/pantheon: set GTK_CSD #66047

Merged
merged 3 commits into from Aug 5, 2019
Merged

nixos/pantheon: set GTK_CSD #66047

merged 3 commits into from Aug 5, 2019

Conversation

worldofpeace
Copy link
Contributor

@worldofpeace worldofpeace commented Aug 5, 2019 •
edited

Motivation for this change

See commit messages.

This will make:

  • applications like ideogram work properly in Pantheon
  • allow the filechooser module to work in all cases
  • dialogs won't have a titlebar

Though it can cause problems in gala

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@worldofpeace
nixos/pantheon: set GTK_CSD
399ff42 
Causes various issues when not set
* elementary/files#971
* elementary/default-settings#103
* cassidyjames/ideogram#26

However this can cause certain problems in gala
* elementary/gala#244
@worldofpeace
nixos/pantheon: use filechooser module
d745487 
Setting GTK_CSD=1 works around the issue
we were having with this [0]

[0]: elementary/files#971
@worldofpeace
pantheon.elementary-files: multi outputs
1d0a54f
@worldofpeace
Copy link
Contributor Author

Checked in a vm everything was fine.

@worldofpeace worldofpeace merged commit 08ea10a into NixOS:master Aug 5, 2019
@worldofpeace worldofpeace deleted the pantheon/envars branch August 5, 2019 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 6.topic: pantheon The Pantheon desktop environment 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@worldofpeace