Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dotnet.sdk: 2.2.300/2.2.5 -> 2.2.401/2.2.6 #66057

Merged
merged 1 commit into from Aug 12, 2019
Merged

dotnet.sdk: 2.2.300/2.2.5 -> 2.2.401/2.2.6 #66057

merged 1 commit into from Aug 12, 2019

Conversation

jirkadanek
Copy link
Member

@jirkadanek jirkadanek commented Aug 5, 2019 •
edited

Motivation for this change

Fixes NuGet/Home#7802 (dotnet list package bug in some projects)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @kuznero

@jirkadanek jirkadanek mentioned this pull request Aug 5, 2019
Closed
@mmahut
Copy link
Member

mmahut commented Aug 12, 2019

I have tested and merged #63654, would you like to rebase your update?

@jirkadanek
Copy link
Member Author

all right, let me get to it

@jirkadanek jirkadanek changed the title dotnet.sdk: 2.2.203/2.2.4 -> 2.2.401/2.2.6 dotnet.sdk: 2.2.300/2.2.5 -> 2.2.401/2.2.6 Aug 12, 2019
@mmahut
Copy link
Member

mmahut commented Aug 12, 2019

@GrahamcOfBorg build dotnet-sdk

mmahut
mmahut approved these changes Aug 12, 2019
View reviewed changes
Copy link
Member

@mmahut mmahut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • reviewed the diff and commit messages
  • made sure ofBorg build succeeded for all applicable platforms
  • run nix-review without any failures
  • run and tested the binaries, using Wassabi

@mmahut mmahut merged commit 9033330 into NixOS:master Aug 12, 2019
@jirkadanek jirkadanek deleted the jd_netcore branch August 12, 2019 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmahut mmahut mmahut approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nuget.xplat list errors when there is msbuild sdk
3 participants
@jirkadanek @mmahut @jiridanek