Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

virtualbox: 5.2.26 → 5.2.28 #60397

Merged
merged 1 commit into from Apr 30, 2019
Merged

virtualbox: 5.2.26 → 5.2.28 #60397

merged 1 commit into from Apr 30, 2019

Conversation

artemist
Copy link
Member

@artemist artemist commented Apr 29, 2019 •
edited

Motivation for this change

VirtualBox is out of date

Things done

Update the version and hashes in the package

Note that at the time of posting, the HTTPS update site is down, so it will fail to build unless you manually prefetch it from the HTTP site.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from svanderburg and flokli April 29, 2019 00:33
@cdepillabout
Copy link
Member

@GrahamcOfBorg build virtualbox

@cdepillabout
Copy link
Member

cdepillabout commented Apr 30, 2019 •
edited

Note that there is also a WIP PR for virtualbox-6, although I think we should go ahead and merge this PR in (and backport to 19.03?) because the virtualbox-6 PR still looks like it will take some time:

#53120

@artemist
Copy link
Member Author

VirtualBox 6.0 is having some trouble with nested virtualization. I may work on fixing that test, but I believe that this is useful as a stop-gap measure.

@alyssais alyssais merged commit c9fd609 into NixOS:master Apr 30, 2019
@flokli
Copy link
Contributor

flokli commented Apr 30, 2019

Right, as long as virtualbox 6 seems broken, we should still keep the 5.x variant up to date.

I built different virtualbox flavours and both free and unfree vm tests passed.

Thanks a lot @artemist! This should be backported too IMHO.

@flokli flokli mentioned this pull request May 1, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svanderburg svanderburg Awaiting requested review from svanderburg

@flokli flokli Awaiting requested review from flokli

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@artemist @cdepillabout @flokli @alyssais