Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wol: fix manpage generation #60310

Merged
merged 1 commit into from Apr 27, 2019
Merged

wol: fix manpage generation #60310

merged 1 commit into from Apr 27, 2019

Conversation

peterhoeg
Copy link
Member

Motivation for this change

perl was missing which is needed to generate the man page.

Cc: @makefu

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 merged commit 2a72ad4 into NixOS:master Apr 27, 2019
@Mic92
Copy link
Member

Mic92 commented Apr 27, 2019

could be backported.

@peterhoeg peterhoeg deleted the f/wol branch April 27, 2019 14:40
@makefu
Copy link
Contributor

makefu commented Apr 27, 2019

Thanks!

@peterhoeg peterhoeg mentioned this pull request Apr 29, 2019
Merged
10 tasks
@peterhoeg peterhoeg restored the f/wol branch April 29, 2019 06:49
@peterhoeg peterhoeg deleted the f/wol branch April 29, 2019 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@peterhoeg @Mic92 @makefu