Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

documize-module: refactor and add more options #60309

Merged
merged 1 commit into from Apr 28, 2019
Merged

documize-module: refactor and add more options #60309

merged 1 commit into from Apr 28, 2019

Conversation

elseym
Copy link
Member

@elseym elseym commented Apr 27, 2019 •
edited

Motivation for this change

adds all available command line switches and some more documentation

/cc @Ma27

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@elseym elseym requested a review from infinisil as a code owner April 27, 2019 09:16
Ma27
Ma27 reviewed Apr 27, 2019
View reviewed changes
Copy link
Member

@Ma27 Ma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for improving this module! I left two minor comments that should be addressed before merging. Apart from that I'm fully 👍

nixos/modules/services/web-apps/documize.nix Outdated Show resolved Hide resolved
nixos/modules/services/web-apps/documize.nix Outdated Show resolved Hide resolved
@Ma27
Copy link
Member

Ma27 commented Apr 28, 2019

@GrahamcOfBorg test documize

@Ma27 Ma27 merged commit a210440 into NixOS:master Apr 28, 2019
@Ma27
Copy link
Member

Ma27 commented Apr 28, 2019

@elseym thanks!

@elseym elseym deleted the documize-2 branch April 28, 2019 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 approved these changes

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos 8.has: documentation 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@elseym @Ma27