luarocks-nix,luaPackages: formatting and additions; awesome: docs! #60343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems fine from the first reading |
|
Overall fine. |
Mostly formatting improvements, basexx apparently has new version which was picked up.
* no leading whitespace * collapse consecutive blank lines to single line * indent fromJSON bits
Especially useful when using non-release versions, but good to have locally regardless.
dtzWill
force-pushed
the
fix/luarocks-nix-formatting-and-awesome-doc-goodness
branch
from
93417fa
to
403ce6a
Compare
7c6f434c
approved these changes
May 10, 2019
|
Whoa I thought was merged :3, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I wanted the wonderful generated docs from awesome,
but needed some new lua modules for this to happen.
Along the way worked on formatting generated by luarocks-nix,
but even so ultimately did a bit of post-processing.
Marking draft because I don't want to actually point to my fork
but haven't sent the changes upstream
(which may need some tweaks or whatnot to be satisfactory).
cc @teto
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)