Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix lua53Packages.lua #60340

Merged
merged 1 commit into from Apr 28, 2019
Merged

fix lua53Packages.lua #60340

merged 1 commit into from Apr 28, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Apr 27, 2019

Motivation for this change

Recent reworking broke lua53Packages.*, root cause
being that lua53Packages.lua didn't have the overrides
needed for the build to succeed.

Instead of overrideAttrs, just plumb the needed additions
directly into the mkDerivation call.

  • Check lua53Packages.lua builds successfully
  • Check lua53Packages.lua and lua5_3 are same derivation
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill dtzWill requested a review from teto April 28, 2019 03:35
@teto
Copy link
Member

teto commented Apr 28, 2019

I never use lua5XPackages and in fact I wonder if they shouldn't be removed since when overriding lua or python from overlays, they are not updated and need to be "re-set" via for instance : python3Packages = python3.pkgs;. They don't bring anything to the table.
I like the idea of chaining override/overrideAttrs but I don't know enough of the details to know when it can break.
Anyway I'll merge this to prevent further problems.

@teto teto merged commit d0bac7d into NixOS:master Apr 28, 2019
@dtzWill dtzWill mentioned this pull request May 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teto teto Awaiting requested review from teto

Assignees
No one assigned
Labels
6.topic: lua 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dtzWill @teto