Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dbeaver: 6.0.2 -> 6.0.3 #60344

Merged
merged 1 commit into from Apr 28, 2019
Merged

dbeaver: 6.0.2 -> 6.0.3 #60344

merged 1 commit into from Apr 28, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Apr 27, 2019

Motivation for this change

https://dbeaver.io/2019/04/21/dbeaver-6-0-3/

Using 6.0.2, on launch it tells you new version is available
and fills your screen with how great it is. xD.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

aanderse
aanderse approved these changes Apr 28, 2019
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built your branch locally, ran it, connected to a mysql database. Seems like bot is having some issues. LGTM 👍

@dtzWill
Copy link
Member Author

dtzWill commented Apr 28, 2019

Yeah borg's eval checks are funky right now, dunno. Thanks for the review/testing!

@dtzWill dtzWill merged commit 9ec59a1 into NixOS:master Apr 28, 2019
@dtzWill dtzWill deleted the update/dbeaver-6.0.3 branch April 28, 2019 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanderse aanderse aanderse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dtzWill @aanderse