Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

taskell: 1.3.2 -> 1.4.2 #60363

Merged
merged 2 commits into from May 7, 2019
Merged

taskell: 1.3.2 -> 1.4.2 #60363

merged 2 commits into from May 7, 2019

Conversation

matthiasbeyer
Copy link
Contributor

Motivation for this change

https://github.com/smallhadroncollider/taskell/issues/33

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@matthiasbeyer
taskell: 1.3.2 -> 1.4.0
cb5f090 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@dtzWill
Copy link
Member

dtzWill commented Apr 28, 2019

Works here! Should we bump to 1.4.2 while we're at it?

@matthiasbeyer
Copy link
Contributor Author

lol. Yes, I'm on it.

@matthiasbeyer
Copy link
Contributor Author

hmh,... having problems with cache.nixos.org SSL cert... maybe a bit later...

@BenBals
Copy link
Contributor

BenBals commented Apr 29, 2019

Reviewed points
  • package path fits guidelines
  • package name fits guidelines
  • package version fits guidelines
  • package build on Linux nixos-beb 4.19.34 Compile glibc without -fstack-protector. #1-NixOS SMP Fri Apr 5 20:33:17 UTC 2019 x86_64 GNU/Linux
  • executables tested on Linux nixos-beb 4.19.34 Compile glibc without -fstack-protector. #1-NixOS SMP Fri Apr 5 20:33:17 UTC 2019 x86_64 GNU/Linux
  • meta.description is set and fits guidelines
  • meta.license fits upstream license
  • meta.platforms is set
  • meta.maintainers is set
  • build time only dependencies are declared in nativeBuildInputs
  • source is fetched using the appropriate function
  • phases are respected
  • patches that are remotely available are fetched with fetchpatch
Possible improvements
Comments

@matthiasbeyer matthiasbeyer changed the title taskell: 1.3.2 -> 1.4.0 taskell: 1.3.2 -> 1.4.2 May 2, 2019
@matthiasbeyer
Copy link
Contributor Author

taskell 1.4.2 fails for me:

rm ~/.config/taskell/*
./result/bin/taskell 
taskell: /home/user/.config/taskell/config.ini: hGetContents: invalid argument (invalid byte sequence)

Reverting latest change.

@matthiasbeyer
taskell: 1.4.0 -> 1.4.2
a0f644f 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@BenBals
Copy link
Contributor

BenBals commented May 2, 2019

The current state of the PR builds and executes fine for me. (Though I have no actual taskell data to test it on. It creates a new file and edits it fine.)

@matthiasbeyer
Copy link
Contributor Author

OK, maybe problems with my test VM

@matthiasbeyer
Copy link
Contributor Author

It was indeed an error in my setup, some weird encoding stuff.

Ready to merge from my POV.

@matthiasbeyer
Copy link
Contributor Author

@GrahamcOfBorg build taskell

@dtzWill
Copy link
Member

dtzWill commented May 7, 2019

(1.4.3? ^_^)

@matthiasbeyer
Copy link
Contributor Author

Oh damn. Okay, maybe I have time tomorrow. Can we please merge this, I'll open a new PR for the next update asap.

@dtzWill
Copy link
Member

dtzWill commented May 7, 2019

Sure!

@dtzWill dtzWill merged commit 5f13ffc into NixOS:master May 7, 2019
@matthiasbeyer matthiasbeyer deleted the update-taskell branch May 7, 2019 18:52
@matthiasbeyer matthiasbeyer mentioned this pull request May 8, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@matthiasbeyer @dtzWill @BenBals