Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xmobar: Add xmobar toplevel (backport to 19.03) #60362

Merged
merged 1 commit into from Apr 28, 2019
Merged

xmobar: Add xmobar toplevel (backport to 19.03) #60362

merged 1 commit into from Apr 28, 2019

Conversation

cdepillabout
Copy link
Member

@cdepillabout cdepillabout commented Apr 28, 2019 •
edited

Motivation for this change

This backports #56425 to 19.03.

#56425 adds xmobar to pkgs/top-level/all-packages.nix. The justification is on that PR.

Pinging @catern (the author of the original PR) and @srhb (the committer for the original PR).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@catern @cdepillabout
xmobar: add to all-packages so it shows up in search
43cd1c7 
People are confused when they "nix search" for xmobar (a standalone
application which just happens to be written in Haskell) and don't
find it; they assume xmobar is not actually packaged. They have to
have special Nix knowledge to know that they should look in
haskellPackages for xmobar.

Let's just put xmobar in all-packages.nix so it shows up in search,
and people can install it straightforwardly without knowing about
haskellPackages.

(cherry picked from commit 8e530a4)
@cdepillabout
Copy link
Member Author

@GrahamcOfBorg build xmobar

@srhb srhb merged commit 88d9ce6 into NixOS:release-19.03 Apr 28, 2019
@cdepillabout cdepillabout deleted the add-xmobar-toplevel branch April 29, 2019 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cdepillabout @srhb @catern