Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

carla: init at 2.0.0 #60346

Merged
merged 1 commit into from May 23, 2019
Merged

carla: init at 2.0.0 #60346

merged 1 commit into from May 23, 2019

Conversation

minijackson
Copy link
Member

Motivation for this change

To have more choices in audio production software. Carla seems fairly used by people using the Jack ecosystem. #11190 mentions Carla, so @Pitometsu, @joelmo and @magnetophon might be interested.

Tested (a bit) from the release-19.03 branch because I don't have the resources of compiling QT from scratch ^^

If someone with a more complete audio setup wants to test it, I'd be happy :D

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@magnetophon
Copy link
Member

magnetophon commented Apr 27, 2019 •
edited

Thanks for making this, I'm very interested!

I cherrypicked the commit on unstable, and when I ran carla I got:

  File "/nix/store/146pjlvrf3rwccpkbf5qkpc1mgh0laqb-carla-2.0.0/share/carla/carla", line 2
    export PATH='/nix/store/kimimvhimclyfzlncpg36zjni3wn70nq-python3-3.7.3/bin:/nix/store/a34f16h8ih6dvvr11fwfjbij0vck8zyq-python3.7-rdflib-4.2.2/bin:/nix/store/rpayih9fb4ms2wjvmyn6kp7kmsizim49-python3.7-setuptools-40.8.0/bin:/nix/store/p351a2bc6zvi4vicdrjwvj4ypls1cfsq-python3.7-pyliblo-0.10.0/bin:/nix/store/rlx99nx951mb919x96viv6hfr5hxa4l0-python3.7-PyQt-5.11.3/bin'${PATH:+':'}$PATH
              ^
SyntaxError: invalid syntax

@FRidh
Copy link
Member

FRidh commented Apr 28, 2019

@GrahamcOfBorg eval

@minijackson
Copy link
Member Author

Welp, I must have missed something or tested the wrong result, sorry about that :-/ It should be fixed, now

@magnetophon
Copy link
Member

All working now; great!
I'll test some more tonight.

@veprbl veprbl requested a review from FRidh April 28, 2019 16:51
@minijackson
Copy link
Member Author

Thanks for the review @veprbl !

@magnetophon
Copy link
Member

Works just fine here, thanks!

@veprbl
Copy link
Member

veprbl commented May 2, 2019

@GrahamcOfBorg build carla

@minijackson
Copy link
Member Author

Thanks for the pointer @FRidh

Also added which to the PATH, else I couldn't get it to run in a --pure nix shell

@veprbl
Copy link
Member

veprbl commented May 23, 2019

@GrahamcOfBorg build carla

@veprbl veprbl merged commit d8d85a2 into NixOS:master May 23, 2019
@minijackson minijackson deleted the init-carla branch May 26, 2019 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl left review comments

@FRidh FRidh FRidh left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@minijackson @magnetophon @FRidh @veprbl