nixos/luksroot: GPG Smartcard support for luks encrypted volumes in initrd #60372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemist
reviewed
Apr 30, 2019
| description = '' | ||
| The option to use this LUKS device with a GPG encrypted luks password by the GPG Smartcard. | ||
| If null (the default), GPG-Smartcard will be disabled for this device. | ||
| Yubikey and GPG Card may not be used at the same time. |
There was a problem hiding this comment.
If you can't use yubikey and gpg card at the same time, you may want to add an assertion to config.assertions.
There was a problem hiding this comment.
@artemist I have added the assertion.
marenz2569
changed the title
|
This PR broken older PR for trezor support, check #60774 |
petrkr
reviewed
May 13, 2019
| } | ||
| ''} | ||
|
|
||
| ${if (luks.yubikeySupport && (yubikey != null)) || (luks.gpgSupport && (gpgCard != null)) then '' |
There was a problem hiding this comment.
So if there will be 10 or 20 HW ways how to open luks device, this IF will be endless ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I do want to decrypt my luks volumes with a gpg smart card.
You manually have to encrypt the passphrase for the decryption of luks and specify the gpg encrypted file.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)