Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mosh: upstream patch to fix w/newer clang/libcxx (c++17) #60419

Merged
merged 1 commit into from Jun 1, 2019
Merged

mosh: upstream patch to fix w/newer clang/libcxx (c++17) #60419

merged 1 commit into from Jun 1, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Apr 29, 2019

Remove special-casing no longer needed.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill
mosh: upstream patch to fix w/newer clang/libcxx (c++17)
208fbe2 
Remove special-casing no longer needed.
@ofborg ofborg bot requested a review from viric April 29, 2019 13:18
@matthewbauer
Copy link
Member

Awesome! This is definitely useful. There's also a patch for libjack2 available that should work:

jackaudio/jack2@d851fad

Ekleog
Ekleog approved these changes Jun 1, 2019
View reviewed changes
Copy link
Member

@Ekleog Ekleog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dtzWill Is this blocked on something else or can we merge?

@matthewbauer matthewbauer merged commit 01390dc into NixOS:staging Jun 1, 2019
@dtzWill
Copy link
Member Author

dtzWill commented Jun 1, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ekleog Ekleog Ekleog approved these changes

@viric viric Awaiting requested review from viric

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @matthewbauer @Ekleog