Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quaternion: 0.0.9.4-rc3 -> 0.0.9.4 #60418

Merged
merged 1 commit into from Apr 29, 2019
Merged

quaternion: 0.0.9.4-rc3 -> 0.0.9.4 #60418

merged 1 commit into from Apr 29, 2019

Conversation

peterhoeg
Copy link
Member

Motivation for this change

I feel a little bit silly about merging the new quaternion-git this morning...

https://github.com/QMatrixClient/Quaternion/releases/tag/0.0.9.4

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill
Copy link
Member

dtzWill commented Apr 29, 2019

LGTM! Haha re:the timing, but the release has been baking for some time, enjoying the release! Thanks!

@dtzWill dtzWill merged commit 54b7ee4 into NixOS:master Apr 29, 2019
@peterhoeg peterhoeg deleted the u/quaternion_0094 branch April 30, 2019 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@peterhoeg @dtzWill