Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

waifu2x-converter-cpp: init at 5.2.4 #60399

Merged
merged 1 commit into from Apr 30, 2019
Merged

waifu2x-converter-cpp: init at 5.2.4 #60399

merged 1 commit into from Apr 30, 2019

Conversation

xzfc
Copy link
Contributor

@xzfc xzfc commented Apr 29, 2019

Motivation for this change

Add waifu2x-converter-cpp, an anime image superresolution tool.
Tested on NVIDIA CUDA, and CPU. Not tested on OpenCL/AMDGPU.
Previous PR: #50398.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

c0bw3b
c0bw3b requested changes Apr 29, 2019
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes, otherwise LGTM

pkgs/tools/graphics/waifu2x-converter-cpp/default.nix Outdated Show resolved Hide resolved
pkgs/tools/graphics/waifu2x-converter-cpp/default.nix Outdated Show resolved Hide resolved
pkgs/tools/graphics/waifu2x-converter-cpp/default.nix Outdated Show resolved Hide resolved
@xzfc
Copy link
Contributor Author

xzfc commented Apr 30, 2019

Updated.

@c0bw3b
Copy link
Contributor

c0bw3b commented Apr 30, 2019

@GrahamcOfBorg build waifu2x-converter-cpp

@c0bw3b c0bw3b merged commit d6e4ed7 into NixOS:master Apr 30, 2019
@xzfc xzfc deleted the waifu2x-converter-cpp branch April 30, 2019 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xzfc @c0bw3b