Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bazelisk: 0.0.3 -> 0.0.4 #60404

Merged
merged 1 commit into from Apr 30, 2019
Merged

bazelisk: 0.0.3 -> 0.0.4 #60404

merged 1 commit into from Apr 30, 2019

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Apr 29, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from kalbasit April 29, 2019 02:42
@JohnAZoidberg
Copy link
Member

JohnAZoidberg commented Apr 29, 2019 •
edited

Does this tool work on NixOS?

I get:

[nix-shell:~/.cache/nix-review/pr-60404]$ ./results/bazelisk/bin/bazelisk  -h
2019/04/29 04:43:42 Downloading https://releases.bazel.build/0.24.1/release/bazel-0.24.1-linux-x86_64...
2019/04/29 04:43:57 could not run Bazel: could not start Bazel: fork/exec /home/zoid/.cache/bazelisk/bin/bazel-0.24.1-linux-x86_64: no such file or directory

Seems to download the Bazel executable for a generic distro. This doesn't work on NixOS because we don't have the dynamic linker at the same path.

Otherwise the update is fine.

@marsam
Copy link
Contributor Author

marsam commented Apr 29, 2019

it works fine on darwin, and —I'm guessing— in other Linux distributions

$ nix-build -A bazelisk
/nix/store/sxx04nqwz2sqg6yaqnyv33zp52m1qvwk-bazelisk-0.0.4
$ result/bin/bazelisk version
2019/04/28 22:25:18 Downloading https://releases.bazel.build/0.24.1/release/bazel-0.24.1-darwin-x86_64...
WARNING: --batch mode is deprecated. Please instead explicitly shut down your Bazel server using the command "bazel shutdown".
Build label: 0.24.1
Build target: bazel-out/darwin-opt/bin/src/main/java/com/google/devtools/build/lib/bazel/BazelServer_deploy.jar
Build time: Tue Apr 2 16:32:47 2019 (1554222767)
Build timestamp: 1554222767
Build timestamp as int: 1554222767

but fails on NixOS, and is not trivial to fix:

$ ldd /home/marsam/.cache/bazelisk/bin/bazel-0.24.1-linux-x86_64
	linux-vdso.so.1 (0x00007ffca7593000)
	librt.so.1 => /nix/store/681354n3k44r8z90m35hm8945vsp95h1-glibc-2.27/lib/librt.so.1 (0x00007fbc99d29000)
	libdl.so.2 => /nix/store/681354n3k44r8z90m35hm8945vsp95h1-glibc-2.27/lib/libdl.so.2 (0x00007fbc99d24000)
	libpthread.so.0 => /nix/store/681354n3k44r8z90m35hm8945vsp95h1-glibc-2.27/lib/libpthread.so.0 (0x00007fbc99d03000)
	libm.so.6 => /nix/store/681354n3k44r8z90m35hm8945vsp95h1-glibc-2.27/lib/libm.so.6 (0x00007fbc99b6d000)
	libstdc++.so.6 => not found
	libgcc_s.so.1 => /nix/store/681354n3k44r8z90m35hm8945vsp95h1-glibc-2.27/lib/libgcc_s.so.1 (0x00007fbc99957000)
	libc.so.6 => /nix/store/681354n3k44r8z90m35hm8945vsp95h1-glibc-2.27/lib/libc.so.6 (0x00007fbc9979f000)
	/lib64/ld-linux-x86-64.so.2 => /nix/store/681354n3k44r8z90m35hm8945vsp95h1-glibc-2.27/lib64/ld-linux-x86-64.so.2 (0x00007fbc99d35000)

I think we could add a warning in meta.longDescription, what do you think?

@marsam marsam merged commit 00361ee into NixOS:master Apr 30, 2019
@marsam marsam deleted the update-bazelisk branch April 30, 2019 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marsam @JohnAZoidberg