Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flow: 0.97.0 -> 0.98.0 #60403

Merged
merged 1 commit into from Apr 29, 2019
Merged

flow: 0.97.0 -> 0.98.0 #60403

merged 1 commit into from Apr 29, 2019

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Apr 29, 2019

Motivation for this change

Changelog: https://github.com/facebook/flow/releases/tag/v0.98.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from globin April 29, 2019 02:41
JohnAZoidberg
JohnAZoidberg approved these changes Apr 29, 2019
View reviewed changes
Copy link
Member

@JohnAZoidberg JohnAZoidberg left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it on https://github.com/facebook/flow/tree/master/examples/01_HelloWorld.
Works! :)

@marsam marsam merged commit 372c0b0 into NixOS:master Apr 29, 2019
@marsam
Copy link
Contributor Author

marsam commented Apr 29, 2019

@JohnAZoidberg thanks for testing!

@marsam marsam deleted the update-flow branch April 29, 2019 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnAZoidberg JohnAZoidberg JohnAZoidberg approved these changes

@globin globin Awaiting requested review from globin

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marsam @JohnAZoidberg