Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mate.mate-control-center: look up keyboard shortcuts in system data dirs #60401

Merged
merged 1 commit into from May 1, 2019
Merged

mate.mate-control-center: look up keyboard shortcuts in system data dirs #60401

merged 1 commit into from May 1, 2019

Conversation

romildo
Copy link
Contributor

@romildo romildo commented Apr 29, 2019

Motivation for this change

Fixes #60400.

The mate keybinding properties does not include window management actions, provided by the marco (the mate window manager) package.

Screenshot from 2019-04-28 22-29-45

Mate control center looks for keybinding shortcuts in files located at ${mate-control-center}/share/mate-control-center/keybindings/.

Marco installs its keybinding shortcut files at ${marco}/share/mate-control-center/keybindings/, which is not being used by the mate control center.

This PR:

  • changes mate control center to look for keybinding shortcut files in the system data dirs (defined by the XDG_DATA_DIRS environment variable in the freedesktop standards), inspired by gnome-control-center
  • adds ${marco}/share to XDG_DATA_DIRS in the wrapper for the mate control center applications.

Tested on a virtual machine.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@romildo romildo mentioned this pull request Apr 29, 2019
Merged
@romildo
Copy link
Contributor Author

romildo commented Apr 29, 2019

The patch has been submitted upstream: mate-desktop/mate-control-center#434

@romildo romildo requested a review from jtojnar April 29, 2019 20:45
worldofpeace
worldofpeace approved these changes Apr 30, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, however I'm not sure if patch-diff.githubusercontent.com is a stable source.

@romildo
Copy link
Contributor Author

romildo commented May 1, 2019

LGTM, however I'm not sure if patch-diff.githubusercontent.com is a stable source.

@worldofpeace, would it be better to use a local patch file?

@worldofpeace
Copy link
Contributor

@romildo Maybe fetch from the commit in your fork and be sure to not delete it?

Local patch is fine also because there's an upstream PR (so eventually fetching can happen).

@romildo
Copy link
Contributor Author

romildo commented May 1, 2019

Local patch is fine also because there's an upstream PR (so eventually fetching can happen).

Opted for a local patch file.

@worldofpeace
Copy link
Contributor

Looks right in a VM to me

Screenshot from 2019-05-01 12 38 16

Think I can see the window management actions.

@romildo romildo merged commit f930293 into NixOS:master May 1, 2019
@worldofpeace worldofpeace mentioned this pull request May 18, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mate keybinding properties misses window management
2 participants
@romildo @worldofpeace