Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GSGoal.QuestionClient sends message to wrong client #7534

Closed
ldpl opened this issue Apr 21, 2019 · 1 comment · Fixed by #7560
Closed

GSGoal.QuestionClient sends message to wrong client #7534

ldpl opened this issue Apr 21, 2019 · 1 comment · Fixed by #7560

Comments

@ldpl
Copy link
Contributor

ldpl commented Apr 21, 2019

CmdGoalQuestion uses client index instead of client id but indexes are not synced on network so whoever receives it is somewhat random.
Problem with sending client_id though is that it needs 32 bits and CmdGoalQuestion only have 27 available.
Technically it can be squeezed there as only 10 bits is needed to send 988 possible button combinations but enumerating them isn't fun.
So... any other ideas?
@ldpl
Copy link
Contributor Author

ldpl commented Apr 27, 2019 •
edited

After a bit of though imo best solution atm would be to somehow do a 8-bit client id. After all there can only be 255 clients and 32-bit client id is only useful during connection phase. As how to do that I think of moving client creation into command queue as it's done for companies so that indexes will automatically become synced. Or mb just do some kind of sync index / set id command.

@ldpl ldpl mentioned this issue May 3, 2019
Merged
@LordAro LordAro mentioned this issue Jan 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make GSGoal.QuestionClient work correctly at least for clients with ID < 2**16 ldpl/OpenTTD
1 participant
@ldpl